Repository navigation
docs: Code Coverage badge with the pytest logo, next to the README title - #24
Merged
Merged
Conversation
…title The owner's call: the measured coverage is shown in the title line, labelled "Code Coverage", rather than in the row of badges below it. The badge still links to the full report on the docs site. Chose pytest's logo over a coverage service's because the tests run under pytest (coverage.py, which has no logo, measures them through pytest-cov), and a service's logo would suggest one this project does not use. Residual risk, accepted by the owner: the badge's alt text joins the H1, so screen readers read "PythonMetaTrader5 Code Coverage".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the coverage badge next to the
PythonMetaTrader5title and labels it Code Coverage with the pytest logo, as the owner asked. It still links to the full line-by-line report at https://akinzou.github.io/MetaTrader5-Python/coverage/.scripts/coverage_badge.pywriteslabel: Code Coverage,namedLogo: pytest,logoColor: white. The README badge reads them from the site'scoverage.json, which the docs deploy updates.Verification: ruff, mypy, pytest (434 passed, 100.00% coverage), file length,
mkdocs build --strict, publish dry run withtwine check --strict. A preview render was checked visually./code-review high: 4 findings. Fixed: the logo comment wrongly said pytest measures the number (coverage.py does, through pytest-cov), and a comment duplicated in the test. Kept as the owner decided: the badge in the H1 (its alt text joins the heading for screen readers) and the title-case label.